Remove ldg_ptr and Replace Functionality by const_ptr_deref #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch perftest |
|
Hi there, this is jenkins continuous integration... |
|
launch jenkins |
havogt
approved these changes
Oct 29, 2024
|
launch jenkins |
|
launch perftest |
This reverts commit f819270.
|
launch perftest |
|
launch perftest |
|
launch jenkins |
havogt
approved these changes
Oct 30, 2024
havogt
pushed a commit
that referenced
this pull request
Oct 30, 2024
No performance change in the GridTools performance tests visible, however this might change performance of external code that does not rely on GridTools storages but uses `sid::composite` or `sid::dimension_to_tuple_like` which now use `__ldg` but previously did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No performance change in the GridTools performance tests visible, however this might change performance of external code that does not rely on GridTools storages but uses
sid::compositeorsid::dimension_to_tuple_likewhich now use__ldgbut previously did not.